-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependent variable dictionary - definitive and inside hybrid kernel #120
Closed
alopezrivera
wants to merge
148
commits into
tudat-team:master
from
alopezrivera:dependent_variable_dict
Closed
Dependent variable dictionary - definitive and inside hybrid kernel #120
alopezrivera
wants to merge
148
commits into
tudat-team:master
from
alopezrivera:dependent_variable_dict
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rodynamic_coefficients Feature/extended aerodynamic coefficients
Temporarily disbaling docs build to update boost version in conda packages
- ΔV calculation function default type and default value correctly set - Refactored porkchop components to solve import bug
…les' into feature/porkchop_and_hybrid_modules
- Silent hybrid module setup by default - Removed global_frame_orientation argument from porkchop module methods
…id_modules Porkchop plots and hybrid C++/Python kernel modules v2
Commented out CMakeLists portion reposible Documented progress and marked as TODO
- CMakeLists-only compilation - Manual exposure of all kernel modules
…les' into develop
- Added asarray function - Documentation complete - Relocated to hybrid kernel module `numerical_simulation.propagation` - Name chosen
- Retrieval - asarray method - Results equal to those from previous method - result2array compatible with scalar dependent variable dictionaries - Dimensions of vectorial dependent variables
Code merged into develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request building on #115 (which can be closed upon merging this one).
Improvements
Naming
Changed to indicate what the class and function do as of today:
SimulationVariableDict
->DependentVariableDictionary
result2dict
->create_simulation_variable_dictionary
NumPy array conversion
New method
DependentVariableDictionary.asarray
implemented, allowing users to easily retrieve the time history of each dependent variable as a NumPy array. Paired with theDependentVariableDictionary.time_history
attribute this streamlines away the data juggling that was required before to plot dependent variables.The new method works like this:
dep_vars_dict.asarray(<key>)
, where<key>
can be either aSingleDependentVariableSettings
object (or children instance), or the string ID of aSingleDependentVariableSettings
object. That is, the keys used by this method are the same we use to retrieve dependent variable histories in dictionary form from theDependentVariableDictionary
.See the example below as well.
where
(A, B)
is the shape of the dependent variable. The dependent variables arenp.squeeze
d to remove singleton/trivial dimensions, so in the case of a scalar variable(n, A, B)
shape would simply become(n,)
.Testing (dependent_variable_dict (tudat-team/tudatpy#115))
Test added to the tudatpy tests which tests:
DependentVariableDictionary.asarray
method to obtain NumPy arrays from dependent variable history dictionariesSingleArcSimulationResults.dependent_variable_history
tudatpy.util.result2array