Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider transferring logic from FailedMonitorsGroupedByTSCNodeMetric and FailedMonitorsGroupedByTSCInstanceMetric to FailedMonitorsMetric #182

Open
tillschallau opened this issue Oct 24, 2024 · 0 comments
Open

Consider transferring logic from FailedMonitorsGroupedByTSCNodeMetric and FailedMonitorsGroupedByTSCInstanceMetric to FailedMonitorsMetric #182

tillschallau opened this issue Oct 24, 2024 · 0 comments
Assignees
@dominikmaeckel
Labels
code-quality Everything regarding the quality of the code performance Performance improvement
Milestone
Future work

Comments

@tillschallau
Copy link
Member

All three metrics depend on the ValidTSCInstancesPerTSCMetric, and their results are calculated based on the same data.

Consider adding parameters to the FailedMonitorsMetric which switches the output modes.
@tillschallau tillschallau added performance Performance improvement code-quality Everything regarding the quality of the code labels Oct 24, 2024
@tillschallau tillschallau added this to the Future work milestone Oct 24, 2024
@dominikmaeckel dominikmaeckel self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikmaeckel dominikmaeckel

Labels
code-quality Everything regarding the quality of the code performance Performance improvement
Projects
None yet
Milestone
Future work
Development

No branches or pull requests
2 participants
@tillschallau @dominikmaeckel