Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muriscv_nn_avgpool_s16 channel loop #18

Open
christian-herber-nxp opened this issue Nov 15, 2022 · 1 comment
Open

muriscv_nn_avgpool_s16 channel loop #18

christian-herber-nxp opened this issue Nov 15, 2022 · 1 comment
Assignees
Labels
help wanted Extra attention is needed question Further information is requested vector

Comments

@christian-herber-nxp
Copy link

In the average pooling function, you use a while loop on the chCnt, and also set the vector length to it size_t vl = vsetvl_e32m8(chCnt);.

End of the loop, you decrement chCnt--;.

I had a hard time understanding why this would be done. For one, the loop could be converted to a for loop, but also you are just decrementing the vector length until you are working with a vector length of 1.

Was it maybe intended to decrement the chCnt variable by the vector length at the end of the while loop?
like
chCnt -= vl; pSrc += vl;

On a side note, you might not be able to get super long vector length anyway, because the channel count is likely to be low, right? Wouldn't it make sense to apply the vector operation along a different dimension?

@PhilippvK PhilippvK self-assigned this Sep 26, 2024
@PhilippvK PhilippvK added help wanted Extra attention is needed question Further information is requested vector labels Nov 7, 2024
@PhilippvK
Copy link
Member

We will look into this for release v0.3.0 scheduled for end of Jan 2025. Sorry for the delays!

@PhilippvK PhilippvK added this to the Release v0.3.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested vector
Projects
None yet
Development

No branches or pull requests

2 participants