Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to specify goto options #40

Open
tungs opened this issue Oct 20, 2020 · 0 comments
Open

Allow users to specify goto options #40

tungs opened this issue Oct 20, 2020 · 0 comments
Assignees
@tungs
Labels
enhancement New feature or request

Comments

@tungs
Copy link
Owner

tungs commented Oct 20, 2020

It'd beneficial to be able to change the waitUntil behavior (currently set to networkidle0 https://github.com/tungs/timesnap/blob/fdfece3dd7eb7766365b42a7ab3d4b94195d9a3f/index.js#L175. In general, it'd be good to allow the user to specify all page.goto options.

Also see #38, where it seems that overwriting time can interfere with loading the page.
@tungs tungs added the enhancement New feature or request label Oct 20, 2020
@tungs tungs self-assigned this Oct 20, 2020
@tungs tungs mentioned this issue Jan 23, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tungs tungs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tungs