Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE User's Weekly Dashboard #49

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

BE User's Weekly Dashboard #49

wants to merge 13 commits into from

Conversation

stefanjbloom
Copy link
Collaborator

Type of Change

  • feature ⛲
  • documentation update 📃
  • refactor 🧑‍💻
  • testing 🧪

Description

This branch introduces the Dashboard for a user to track their Job apps, Companies, and Contacts. I have not included the logic to filter it by 'weekly' as stated in the comp. Maybe a future issue?

Motivation and Context

A user dashboard is important for this website so that a user can keep tally of what they have done to earn employment via Tracker. It basically serializes a users info and that users CompanySerializer, JobApplicationSerializer and ContactsSerializer. The FE needs this BE to be done so they can start using real data.

I went and combined issue #42 and issue #43 because they needed to be done for me to proceed. Also tested.

Related Tickets

closes #42
closes #11
closes #43

Screenshots (if appropriate):

Added Test?

  • Yes 🫡
  • All previous tests still pass 🥳
    • 120 passing tests in repo EXCEPT 4 tests for /api/v1/users/create_spec. They are all broken and I dunno how to fix. Here it is:

Rspec Fail

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Questions

I'm wondering if the users table and the contacts table will have any issues in the future is a user is ALSO another users contact? Both tables attributes are incongruent w/ each other. Probably not.

I did not create a dashboard class since, at this point, I felt I did not need it. Should I create an issue to create if for future scalability as well as filtering resources so that they expire after a week? See comp of issue #11

Any ideas for DashboardController edge cases I can throw in the mix for the future?

…ted model associations by using dbdiagram.io. route created for dashboard
…user-dashboard

latest main to branch for latest testing and dashboard work
…ing the serialized dashboard json response i want. refactored controllers to allow me to actually get my dashboard the info it needs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Controller Policies Controller Authorizations Refactor User dashboard - BE only
1 participant