Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Use a consistent style around defaults #490

Open
jcoveney opened this issue Apr 1, 2014 · 0 comments
Open

Use a consistent style around defaults #490

jcoveney opened this issue Apr 1, 2014 · 0 comments
Labels
cleanup

Comments

@jcoveney
Copy link
Contributor

jcoveney commented Apr 1, 2014

there is Constants.scala which has a number of defaults, but then there are also many options (AnchorTuples and others) which have a default in their companion object. We should consolidate around one style (I prefer the constants approach).
snoble pushed a commit to snoble/summingbird that referenced this issue Sep 8, 2017
@ianoc
Merge pull request twitter#490 from twitter/jnievelt/489
b6c076f 
Test Semigroup#sumOption using Iterator instead of List
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnynek @jcoveney