Remove lookup join from summingbird-scalding

[johnynek]

https://github.com/twitter/summingbird/blob/develop/summingbird-scalding/src/main/scala/com/twitter/summingbird/scalding/LookupJoin.scala

should be replaced with code in scalding:

https://github.com/twitter/scalding/blob/develop/scalding-core/src/main/scala/com/twitter/scalding/typed/LookupJoin.scala

Looks like the summingbird code has more options, namely the window support, so we need to move that to scalding or accept the duplication.

[adamkozuch]

Should I made this PR adamkozuch/scalding@twitter:develop...develop to Scalding and then remove LookupJoin from summingbird and replace by class from scalding?

[johnynek]

Sure, that would be great. Of course, since these are developed separately, we will have to publish a new version of scalding first.

Also, please double check any tests are exported at the same time.

[adamkozuch]

LookupJoinTest from summingbird use specs2 but LookupJoinTest from scalding use scalatest. Should I just copy test from summingbird or rewrite it to scalatest?

[johnynek]

Well, copy the logic, but make them work with scalatest since that is the
runner we use now.

On Mon, Feb 9, 2015 at 10:55 AM, Adam [email protected] wrote:

LookupJoinTest from summingbird use specs2 but LookupJoinTest from
scalding use scalatest. Should I just copy test from summingbird or rewrite
it to scalatest?

—
Reply to this email directly or view it on GitHub
#515 (comment).

Oscar Boykin :: @posco :: http://twitter.com/posco