Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Make it easy to add metrics to SummerConstructor #711

Open
pankajroark opened this issue Jan 27, 2017 · 0 comments
Open

Make it easy to add metrics to SummerConstructor #711

pankajroark opened this issue Jan 27, 2017 · 0 comments

Comments

@pankajroark
Copy link
Contributor

There are couple things that make adding metrics for replacement SummerBuilder very difficult.

  1. The metrics for regular summer have the node name in them, e.g: summingbird.Tail/tuplesIn. The overridden summer has to know the nodename to use the same metric names.
  2. An implicit job id is required for creating summingbird counters. Most jobs don't set job id by default and are forced to create one for this case.

Instead Counter should be passed to SummerBuilder. SummerBuilder is seldom used so one possibility is to accept breaking backward compatibility in this case. Otherwise a new option can be defined and this one deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant