Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SwiftUI-style HTML Protocol & Site Environment aren't used when creating new project, and project won't finish running #144

Open
B4DG3R opened this issue Nov 14, 2024 · 0 comments

Comments

@B4DG3R
Copy link

B4DG3R commented Nov 14, 2024

Hi All.

I have found 3 issues which I believe may have been caused by the last PR merge (or 2 of them at least).

  1. When creating a new Project the new SwiftUI-style HTML Protocol & Site Environment aren't being used. The project is still being created with the older style context function headers. This could cause a lot of confusion for anyone new starting out with ignite.

  2. After clearing the errors by updating HTML -> HTMLDocument & Body -> HTMLBody etc in line with the new documentation, the @Page private var Page property is giving me an error.

Struct 'Page' cannot be used as an attribute
Type annotation missing in pattern
  1. The project won't seem to finish building, even in a new test project with nothing in it. We hit Build -> the project Runs but it never finishes hence no Build folder is created.

While trying to raise evidence for my PR last night my fork Main branch was behind the main project and there was a merge conflict so I merged in main to clear the conflicts, and even after clearing all of the errors something isn't right.

If someone could take a loooook I would greatly appreciate it. I have taken a look although I feel this issue is slightly out of my depth and may be better suited to the person who implemented the change, as I just can't see the issue 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant