Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to extract structures and relevant properties after recon, gen and opt tasks? #41

Open
chiku-parida opened this issue May 9, 2023 · 7 comments

Comments

@chiku-parida
Copy link

  1. Could you please explain how to extract data from the outputs of recon, gen and opt tasks? @txie-93
  2. How will we control the number of generated structures? example: If someone wants to generate 100 structures
@SourinDeyUW
Copy link

  1. Could you please explain how to extract data from the outputs of recon, gen and opt tasks? @txie-93

    1. How will we control the number of generated structures? example: If someone wants to generate 100 structures

Could you find a solution for it?

@chiku-parida
Copy link
Author

chiku-parida commented Jan 23, 2024

I found an alternative way to extract the generated structures. You can load the files as torch tensors. Then you can extract the related tensors like cell parameters, fractional coordinates etc and then using ASE you can create your generated structure using the extracted tensors or the informations. @SourinDeyUW @yqq2022

@SourinDeyUW
Copy link

I found an alternative way to extract the generated structures. You can load the files as torch tensors. Then you can extract the related tensors like cell parameters, fractional coordinates etc and then using ASE you can create your generated structure using the extracted tensors or the informations. @SourinDeyUW @yqq2022

Thanks for your response. I have tried.
Could you tell me about how good the reconstructed structures were? Did you have to tune hyperparameters yourself?
I simply ran their code and reconstructed to match with ground truth, resulting cifs look very different. I tried for mp-20 data.

@JHWang1001
Copy link

2. How will we control the number of generated structures? example: If someone wants to generate 100 structures

Dear chiku-parida,
Can you solve this problem? When I running cdvae, I only can get 11 structures. However, sometimes I can get 1100 structures. @chiku-parida

@chiku-parida
Copy link
Author

@JHWang1001
Hii...
Are you able to solve the issue?
Sorry for late reply. The generation part is working fine for me. I don't understand how it is just generating random samples irrespective of the user input. Can you provide some more details or generation inputs?

@JHWang1001
Copy link

@JHWang1001 Hii... Are you able to solve the issue? Sorry for late reply. The generation part is working fine for me. I don't understand how it is just generating random samples irrespective of the user input. Can you provide some more details or generation inputs?

Sorry, I can't solve this issue yet.

When I use task gen, I can find up to 50,000 structures from the tensor! But when I use task opt, this amount seems to depend on the training data. The pervo provided by the author generated 345 structures, while the training set I built myself generated only 11 structures. I still don't seem to understand what is the difference between the gen and opt parameters?

If you want to specify how many structures to output (such as cdvae generates 10,000 structures and you want to produce 50 structures) you can write a loop that extracts just 50 structures. Do you need the code?@chiku-parida

Best wishes
Jiahui Wang

@chiku-parida
Copy link
Author

@JHWang1001
The opt task is a part of supervised learning in CDVAE for conditional generation. Somehow I didn't understand the last part you mentioned about the loop that extracts structures. Can you please elaborate? I will look into it again, though I am not using the CDVAE now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants