Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data construction specifics #29

Open
MichaelHopwood opened this issue Aug 20, 2021 · 2 comments
Open

Data construction specifics #29

MichaelHopwood opened this issue Aug 20, 2021 · 2 comments

Comments

@MichaelHopwood
Copy link

Hello,
Thanks for your awesome work! I was wondering if you could provide more details regarding the data construction with the materials project API. Specifically,

  1. Which keys were queried to generate the features (Appendix Table 2)?
    a. Are group & period number included in the API or did you use other methods?
    b. Which keys in materialsproject held electronegativity, valence electrons (nsites?), etc.?

  2. What IDs are saved in atom_init? Do these IDs have to match with information in the CIF files?

Cheers!

@txie-93
Copy link
Owner

txie-93 commented Aug 23, 2021

Thank you for your question. First, the features are for elements, not for crystals. In atom_init, the keys are atomic number of the element, and the values are the initialization vectors for each element.

To generate these features, I used a package called mendeleev. For example, to get the group number for H, you can simply do,

from mendeleev import element

element('H').group_id

@cywbreeze
Copy link

The values, the initialization vectors are all the same, so they're all generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants