Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about fetching Materials Project Data #35

Open
shuix007 opened this issue Apr 1, 2022 · 2 comments
Open

Question about fetching Materials Project Data #35

shuix007 opened this issue Apr 1, 2022 · 2 comments

Comments

@shuix007
Copy link

shuix007 commented Apr 1, 2022

Hi,

Thank you for your great work! I am trying to fetch the data from the Materials Project database based on the mp-ids that you provided. I am wondering if the mp-ids that you provided are materials id or task id?

I tried

MPRester().get_structure_by_material_id(id)

but a lot of the ids in your csv files return void responses. Then I tried

mid = get_materials_id_from_task_id(id)
structure = get_structure_by_material_id(mid)

and it worked. I want to ask if this is the correct way of fetching the dataset.

Thank you

@txie-93
Copy link
Owner

txie-93 commented Apr 3, 2022

Thanks for the question. I used materials ids. Unfortunately, Materials Project retired some of their old materials ids over the past few years. It is difficult to get the exact dataset used in the CGCNN paper that I downloaded in 2017. If you want to benchmark your algorithm against CGCNN, I'd recommend to create your own dataset with the latest Materials Project data. You should get similar results.

@shuix007
Copy link
Author

shuix007 commented Apr 4, 2022

Thank you for your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants