Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion with preprocessing pipeline #26

Open
tjtanaa opened this issue Nov 16, 2020 · 3 comments
Open

Confusion with preprocessing pipeline #26

tjtanaa opened this issue Nov 16, 2020 · 3 comments

Comments

@tjtanaa
Copy link

tjtanaa commented Nov 16, 2020

I have question regarding to your preprocessing pipeline. I have tried to visualize and make sense of your coordinate system and preprocessing pipeline; however, I still could grasp it.

  1. Could I know why would you want to minus -pi/2 when the range of the label is already within the range [-pi, pi]? The following is the snippet of code from processors.py that illustrate that.

    @staticmethod
    def transform_labels_into_lidar_coordinates(labels: List[Label3D], R: np.ndarray, t: np.ndarray):
        transformed = []
        for label in labels:
            label.centroid = label.centroid @ np.linalg.inv(R).T - t
            label.dimension = label.dimension[[2, 1, 0]] # h w l => l ,w ,h
            label.yaw -= np.pi / 2
            while label.yaw < -np.pi:
                 print("smaller than -pi")
                 label.yaw += (np.pi * 2)
            while label.yaw > np.pi:
                 print("larger than pi")
                 label.yaw -= (np.pi * 2)
            transformed.append(label)
        return labels
  1. Moreover, which axes do the width and length correspond to in your coordinate system? Is it w for x axis and l for y axis?
  2. Do I need to offset the z height by height/2 to get the true center of the bounding box in your coordinate system?
@dvrohan
Copy link

dvrohan commented Feb 26, 2021

Also the function returns labels. What is the use of transformed list?

@Manueljohnson063
Copy link

@tjtanaa @dvrohan @kvssraviteja
2021-03-07 17:54:35.720682: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcudnn.so.8
2021-03-07 17:54:37.690026: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcublas.so.11
2021-03-07 17:54:38.183182: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcublasLt.so.11
Scene 1: Box predictions with occupancy > occ_thr: 0
Traceback (most recent call last):
File "point_pillars_prediction.py", line 43, in
nms_boxes = rotational_nms(set_boxes, confidences, occ_threshold=0.7, nms_iou_thr=0.5)
File "/content/drive/MyDrive/PointPillars/inference_utils.py", line 41, in rotational_nms
assert (isinstance(set_boxes[0][0][0][0], float) or isinstance(set_boxes[0][0][0][0], int)) and
IndexError: list index out of range

I put for files in testing folder(4-velodyne,4-calib)
000000,00001,000002,00003
Error is poping out please help !!!!!!!!!!!!!!!!!!!!

@viplix3
Copy link

viplix3 commented Mar 16, 2021

I also have the same confusion as @tjtanaa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants