From cb7861c4cb9c3650feeda3ca4408f2681f20e9c9 Mon Sep 17 00:00:00 2001
From: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Date: Thu, 12 Sep 2024 12:20:24 -0700
Subject: [PATCH] fix(ci): Add 'patches' folder to pipeline triggers that need
 them (#22485)

## Description

Adds the `patches/` folder to pipeline triggers so changes to it cause
relevant pipelines to run.

Also reorders the triggers in the common-utils and protocol-definitions
pipeline to be in alphabetical order.

Related to https://github.com/microsoft/FluidFramework/pull/22484 and
https://github.com/microsoft/FluidFramework/pull/22474.
---
 tools/pipelines/build-client.yml               |  2 ++
 tools/pipelines/build-common-utils.yml         | 10 ++++++++--
 tools/pipelines/build-protocol-definitions.yml | 10 ++++++++--
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/tools/pipelines/build-client.yml b/tools/pipelines/build-client.yml
index 1930645ec754..0cbbe7ff39b5 100644
--- a/tools/pipelines/build-client.yml
+++ b/tools/pipelines/build-client.yml
@@ -89,6 +89,7 @@ trigger:
     - packages
     - PACKAGES.md
     - package.json
+    - patches/*
     - pnpm-lock.yaml
     - pnpm-workspace.yaml
     - prettier.config.cjs
@@ -149,6 +150,7 @@ pr:
     - packages
     - PACKAGES.md
     - package.json
+    - patches/*
     - pnpm-lock.yaml
     - pnpm-workspace.yaml
     - prettier.config.cjs
diff --git a/tools/pipelines/build-common-utils.yml b/tools/pipelines/build-common-utils.yml
index c7da80d295ee..406bc802388b 100644
--- a/tools/pipelines/build-common-utils.yml
+++ b/tools/pipelines/build-common-utils.yml
@@ -39,6 +39,10 @@ trigger:
     - .prettierignore
     - common/build/build-common
     - common/lib/common-utils
+    # Common-utils references files from the patches folder at the root of the repo.
+    # Using the whole folder as dependency because when patch files are updated they might get new names.
+    - patches/*
+    - scripts/*
     - tools/pipelines/build-common-utils.yml
     - tools/pipelines/templates/build-npm-package.yml
     - tools/pipelines/templates/include-set-package-version.yml
@@ -51,7 +55,6 @@ trigger:
     - tools/pipelines/templates/include-use-node-version.yml
     - tools/pipelines/templates/include-process-test-results.yml
     - tools/pipelines/templates/upload-dev-manifest.yml
-    - scripts/*
 
 pr:
   branches:
@@ -65,6 +68,10 @@ pr:
     - .prettierignore
     - common/build/build-common
     - common/lib/common-utils
+    # Common-utils references files from the patches folder at the root of the repo.
+    # Using the whole folder as dependency because when patch files are updated they might get new names.
+    - patches/*
+    - scripts/*
     - tools/pipelines/build-common-utils.yml
     - tools/pipelines/templates/build-npm-package.yml
     - tools/pipelines/templates/include-set-package-version.yml
@@ -73,7 +80,6 @@ pr:
     - tools/pipelines/templates/include-use-node-version.yml
     - tools/pipelines/templates/include-process-test-results.yml
     - tools/pipelines/templates/upload-dev-manifest.yml
-    - scripts/*
 
 variables:
   - template: /tools/pipelines/templates/include-vars.yml@self
diff --git a/tools/pipelines/build-protocol-definitions.yml b/tools/pipelines/build-protocol-definitions.yml
index b35a94437c8a..fe62d3831155 100644
--- a/tools/pipelines/build-protocol-definitions.yml
+++ b/tools/pipelines/build-protocol-definitions.yml
@@ -40,6 +40,10 @@ trigger:
     - fluidBuild.config.cjs
     - common/build/build-common
     - common/lib/protocol-definitions
+    # Protocol-definitions references files from the patches folder at the root of the repo.
+    # Using the whole folder as dependency because when patch files are updated they might get new names.
+    - patches/*
+    - scripts/*
     - tools/pipelines/build-protocol-definitions.yml
     - tools/pipelines/templates/build-npm-package.yml
     - tools/pipelines/templates/include-set-package-version.yml
@@ -52,7 +56,6 @@ trigger:
     - tools/pipelines/templates/include-use-node-version.yml
     - tools/pipelines/templates/include-process-test-results.yml
     - tools/pipelines/templates/upload-dev-manifest.yml
-    - scripts/*
 
 pr:
   branches:
@@ -66,6 +69,10 @@ pr:
     - .prettierignore
     - common/build/build-common
     - common/lib/protocol-definitions
+    # Protocol-definitions references files from the patches folder at the root of the repo.
+    # Using the whole folder as dependency because when patch files are updated they might get new names.
+    - patches/*
+    - scripts/*
     - tools/pipelines/build-protocol-definitions.yml
     - tools/pipelines/templates/build-npm-package.yml
     - tools/pipelines/templates/include-set-package-version.yml
@@ -74,7 +81,6 @@ pr:
     - tools/pipelines/templates/include-use-node-version.yml
     - tools/pipelines/templates/include-process-test-results.yml
     - tools/pipelines/templates/upload-dev-manifest.yml
-    - scripts/*
 
 variables:
   - template: /tools/pipelines/templates/include-vars.yml@self