Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minBy/maxBy definitions are incorrect #22

Open
ericanderson opened this issue Jul 13, 2016 · 1 comment
Open

minBy/maxBy definitions are incorrect #22

ericanderson opened this issue Jul 13, 2016 · 1 comment

Comments

@ericanderson
Copy link

Per the documentation in lodash, they are only to accept an array, not a dictionary nor an object. Also, since the first thing done is a check for (array && array.length), we can conclude that the first parameter is optional (and when Typescript 2 comes along, optional or null).

@ericanderson
Copy link
Author

For completeness:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant