-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a number of options are being set in (Compile, doc) #36
Comments
I noticed this too. Needs: scalacOptions in (Compile, doc) ~= (_.filterNot(
Set(
"-scalajs",
"-deprecation",
"-explain-types",
"-explain",
"-feature",
"-language:existentials,experimental.macros,higherKinds,implicitConversions",
"-unchecked",
"-Xfatal-warnings",
"-Ykind-projector",
"-from-tasty",
"-encoding",
"utf8"
)
)) Thank you for this fix Yurique. |
FYI we are now using the https://github.com/ThoughtWorksInc/sbt-api-mappings plugin and have been able to reduce our necessary configuration to just:
|
I wonder if we can ask an sbt expert like @eed3si9n about this one? At the moment this plugin simply sets It seems like the best solution to this is to set those options only in the Are there other tasks than |
The plugin currently appends to unscoped The three major usages of Looks like the plugin already handles If you only append to Appending to
|
I just stumbled across this issue via this project ( github.com/objektwerks/scalajs/blob/master/build.sbt ). To avoid getting this error during sbt clean test ( java.lang.AssertionError: assertion failed: asTerm called on not-a-Term val ), I had to add scalacOptions ++= Seq("-scalajs") to the build.sbt. Apparently sbt-tpolecat was removing the -scalajs option added by the Scalajs plugin ( addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.10.1") ). |
@objektwerks looks like you are running into #102 |
Very well, then.:) I'll repost the above to #102. Should I remove the above post? Thanks! |
No that's ok, it's good to see the history of these bugs and the underlying discussion on the tickets :D |
I've recently been having issues with doc command and I think
The only workaround I've found is not to publish docs ( Here's my relevant settings: tpolecatScalacOptions += ScalacOptions.release(ScalaSettings.scala213ReleaseValue),
Compile / tpolecatExcludeOptions += ScalacOptions.fatalWarnings addSbtPlugin("org.typelevel" % "sbt-tpolecat" % "0.5.1") |
I think I figured out what is going on, we're adding scalac options outside of the plugin. Ignore the above ^^ it is not a problem if you don't do this. |
when publishing, this results in warnings:
without the plugin:
The text was updated successfully, but these errors were encountered: