Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Expecty and improve macros on long/wide outputs #19

Open
keynmol opened this issue Mar 20, 2024 · 1 comment
Open

Inline Expecty and improve macros on long/wide outputs #19

keynmol opened this issue Mar 20, 2024 · 1 comment

Comments

@keynmol
Copy link
Contributor

keynmol commented Mar 20, 2024

Expecty macro libary has been historically maintained by @Baccata, me, and Eugene Yokota, the current maintainer of the fork.

The code from it has been inlined and improved in the Verify testing framework maintained by Eugene.
Inlining the dependency makes release cycles obviously easier.

I believe it's time we design the assertion macros from scratch, as part of this repo, not separate dependency, and address multiple issues related to how Expecty renders assertion failures. See screenshot for an example of an unusable output.

Once we inline the dependency, this issue can be broken down into actionable, smaller issues.

image

@zainab-ali
Copy link
Contributor

As part of #64 , expecty was replaced with a clue macro that resembles MUnit's clue. It uses a Show typeclass instance to render values.

It doesn't remove rendering issues -clue(intitialized) would still render a long output - but it moves the problem towards providing a better Show instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants