Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make change + release to SBT after plug-in groupId is renamed #22

Open
mcanlas opened this issue Mar 27, 2024 · 1 comment
Open

Make change + release to SBT after plug-in groupId is renamed #22

mcanlas opened this issue Mar 27, 2024 · 1 comment

Comments

@mcanlas
Copy link
Contributor

mcanlas commented Mar 27, 2024

SBT has a hard-coded allow list of test frameworks it supports, implicitly.

SBT can be manually configured in each to support additional test frameworks. Weaver used this method early in its lifetime before implicit support was mainlined (and released) for SBT.

If this artifact has any part of its group/artifact/entrant class name changed, a corresponding change and release should be made in SBT. That or users will have to go back to manual configuration until such release is made.

@Baccata
Copy link
Collaborator

Baccata commented Mar 27, 2024

SBT's actually not gonna have to change at all, the only thing it needs to be aware of is the fully qualified name of the class that implements the test framework interface, which is not gonna change.

https://github.com/sbt/sbt/blob/21a4aaa4d630a9c5616243b068276f85679c224f/testing/src/main/scala/sbt/TestFramework.scala#L32

So because only the maven coordinates will change, and not the FQN of this particular class, users will not be impacted when they upgrade.

However, worth leaving this issue open to PR SBT with the new coordinates in this particular test : https://github.com/sbt/sbt/blob/21a4aaa4d630a9c5616243b068276f85679c224f/sbt-app/src/sbt-test/tests/weaver-cats/build.sbt#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants