Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryInterface missing Schema Name #179

Open
nodejayes opened this issue Dec 19, 2018 · 1 comment
Open

QueryInterface missing Schema Name #179

nodejayes opened this issue Dec 19, 2018 · 1 comment

Comments

@nodejayes
Copy link

Hi,

The first parameter of the bulkInsert function is the table name as string. However, this can also be an object with the schema and Table Name properties if the schema has to be defined.

I would suggest defining a new interface that looks like this:

export interface TableDefinition {
    schema: string;
    tableName: string;
}

Then the first parameter of the bulkInsert function can be turned into a Union Type => string | TableDefinition.

I suspect this affects all functions that have the tableName as parameter.

look this

@AlexanderFalconi
Copy link

A year later this is still a problem. @nodejayes @goenning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants