Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false negative when overriding method #6864

Open
theosotr opened this issue Oct 13, 2024 · 0 comments
Open

false negative when overriding method #6864

theosotr opened this issue Oct 13, 2024 · 0 comments

Comments

@theosotr
Copy link

Command

javac -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
  -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-processor org.checkerframework.checker.nullness.NullnessChecker \
-cp checker-framework-3.47.0/checker/dist/checker.jar Test.java

File

import org.checkerframework.checker.nullness.qual.*;
import java.util.*;

class A {
    <T extends List<Integer>> T m(T x) {
        return x;
    }
}

class B extends A {
    <T extends List<@Nullable Integer>> T m(T x) {
        x.add(null);
        return x;
    }
}


public class Test {
    public static void main(String[] args) {
        A x = new B();
        List<Integer> y = new LinkedList<>();
        x.m(y).get(0).toString();
    }
}

Actual behavior

The code passes the checks, but there's a NPE at runtime

Exception in thread "main" java.lang.NullPointerException: Cannot invoke "java.lang.Integer.toString()" because the return value of "java.util.List.get(int)" is null
        at Test.main(Test.java:22)

Expected behavior

The code should have been rejected because class B changes the signature of the overriden method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants