Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation revision #234

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Documentation revision #234

wants to merge 3 commits into from

Conversation

jindazhao
Copy link
Contributor

@jindazhao jindazhao commented Jun 26, 2021

🎟️ Ticket(s): Closes #233

πŸ‘· Changes: A brief summary of what changes were introduced.

Added Timer component into an example folder located in the src folder to give a guide on future code design

πŸ’­ Notes: Any additional things to take into consideration.

Wait! Before you merge, have you checked the following:

πŸ“· Screenshots
image

image

image

image

Here's how it's supposed to look on the web:

image

To access and run the component on its own, please find the repository here

Checklist

  • Looks good on large screens
  • Looks good on mobile

@jindazhao jindazhao self-assigned this Jun 26, 2021
@jindazhao
Copy link
Contributor Author

Note: errors thrown from styling issues

@jindazhao jindazhao requested review from alvinkam33 and removed request for alvinkam33 June 26, 2021 14:58
@jindazhao jindazhao marked this pull request as ready for review June 26, 2021 15:02
Copy link
Member

@alvinkam33 alvinkam33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe add an image of what they should be able to see, or instructions on how to navigate to the timer page (or I can add that onto the onboarding doc)

@jindazhao
Copy link
Contributor Author

Added screenshots to illustrate component and added repository location to the component

Copy link
Member

@alvinkam33 alvinkam33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement example Model View Controller into src to begin front end refactoring
2 participants