Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs found when testing strict SQL modes #1947

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Nov 22, 2024

  1. Fix filter in Report Generator

    The filter string was filtering out valid values for the Report Generator
    delivery mode. This results in the valid string "E-mail" being converted to
    a null which then getes converted to "E-mail" on the sql load if the
    sql_mode is set empty. _Sigh_
    jpwhite4 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d5ad364 View commit details
    Browse the repository at this point in the history
  2. Update default values for XDUser's fks

    Null is not an allowed value for the not null foreign keys to the organization
    and person tables. This change initializes them to a valid value (-1 == Unknown)
    jpwhite4 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ca89f9c View commit details
    Browse the repository at this point in the history
  3. Fix SQL update string for XDUser

    You can't call SQL function in PDO parameters. This code changes it so the that call to the MySQL
    NOW() function is done good and proper like.
    jpwhite4 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    14ba8ef View commit details
    Browse the repository at this point in the history
  4. Fix storage aggregator.

    The physical_usage column in the fact table is nullable, but the one in the
    aggregates table is not. This updates the load SQL to coalesce the null to 0 if necessary.
    jpwhite4 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    77a0b94 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Configuration menu
    Copy the full SHA
    f0a8edf View commit details
    Browse the repository at this point in the history