Improve visualize tests #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhammadKelanyy
approved these changes
Jan 24, 2024
JacobOaks
approved these changes
Jan 24, 2024
visualize_test.go
Outdated
| @@ -449,6 +449,8 @@ func assertCtorEqual(t *testing.T, expected *dot.Ctor, ctor *dot.Ctor) { | |||
| } | |||
|
|
|||
| func assertCtorsEqual(t *testing.T, expected []*dot.Ctor, ctors []*dot.Ctor) { | |||
| assert.Len(t, ctors, len(expected)) | |||
There was a problem hiding this comment.
Thanks for catching this!
In fact, one step better would probably be making this a require.Len so we stop the test immediately and not panic in the following loop if len(ctors) > len(expected)
JacobOaks
added a commit
to JacobOaks/dig
that referenced
this pull request
Jan 26, 2024
PR uber-go#404 attempted to improve the tests in `visualize_test.go` by requiring length equality on the expected/actual ctors. During CI, this actually uncovered a test failure: ``` --- FAIL: TestDotGraph (0.02s) --- FAIL: TestDotGraph/create_graph_with_one_constructor_and_as_interface_option (0.00s) visualize_test.go:453: Error Trace: visualize_test.go:453 visualize_test.go:117 Error: "[]" should have 1 item(s), but has 0 Test: TestDotGraph/create_graph_with_one_constructor_and_as_interface_option ``` This is because, in this specific test case, the provide was never actually provided because of an error during provide (`t5 did not implement io.Reader`). This commit: * Changes all of the provides that are expected to pass to `RequireProvide` which will fail if the provide fails. * Modifies `t5` to implement `io.Reader`. * Change the test case to expect the provider to only provide the interface in the `fx.As` (`fx.As` does not also provide the actual type) * Add the len check from uber-go#404.
Merged
|
Hey @greeflas, CI uncovered an error running this PR. This is actually due to some incorrect testing logic written by us. Since I don't have permission to update this PR, I have created a separate PR that supersedes this one (it includes your change and fixes the broken test): #405. Thanks for uncovering this issue! |
JacobOaks
added a commit
that referenced
this pull request
Jan 26, 2024
PR #404 attempted to improve the tests in `visualize_test.go` by requiring length equality on the expected/actual ctors. During CI, this actually uncovered a test failure: ``` --- FAIL: TestDotGraph (0.02s) --- FAIL: TestDotGraph/create_graph_with_one_constructor_and_as_interface_option (0.00s) visualize_test.go:453: Error Trace: visualize_test.go:453 visualize_test.go:117 Error: "[]" should have 1 item(s), but has 0 Test: TestDotGraph/create_graph_with_one_constructor_and_as_interface_option ``` This is because, in this specific test case, the provide was never actually provided because of an error during provide (`t5 did not implement io.Reader`). This commit: * Changes all of the provides that are expected to pass to `RequireProvide` which will fail if the provide fails. * Modifies `t5` to implement `io.Reader`. * Change the test case to expect the provider to only provide the interface in the `fx.As` (`fx.As` does not also provide the actual type) * Add the len check from #404.
|
Ok, welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While working on #403 I've noted that unit tests for
Visualize()worked not correctly in some cases.If
CreateGraph()method returns lessCtorelements than expected (and vice versa) - tests will pass.So I fixed assert function and found new bug shown by
create graph with one constructor and as interface optionscenario.