Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visualize tests #404

Closed
wants to merge 2 commits into from
Closed

Improve visualize tests #404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab1fccb
improve visualize tests
greeflas Jan 22, 2024
942de22
use require instead of assert
greeflas Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions visualize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,8 @@ func assertCtorEqual(t *testing.T, expected *dot.Ctor, ctor *dot.Ctor) {
}

func assertCtorsEqual(t *testing.T, expected []*dot.Ctor, ctors []*dot.Ctor) {
assert.Len(t, ctors, len(expected))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

In fact, one step better would probably be making this a require.Len so we stop the test immediately and not panic in the following loop if len(ctors) > len(expected)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


for i, c := range ctors {
assertCtorEqual(t, expected[i], c)
}
Expand Down
Loading