Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #404 attempted to improve the tests in
visualize_test.go
by requiring length equality on the expected/actual ctors.During CI, this actually uncovered a test failure:
This is because in this specific test case, the provide was never actually successful because of an error during provide (
t5 did not implement io.Reader
).This commit:
RequireProvide
which will fail if the provide fails.t5
to implementio.Reader
.fx.As
(fx.As
does not also provide the actual type)This supercedes #404.