[Tally Snapshot] -- add some functionality to histogram snapshot so t… #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat it is easier to test. Add the number of values and durations as well as which buckets have values to enable easier histogram testing
|
|
prateek
reviewed
May 25, 2023
| @@ -660,6 +660,12 @@ type HistogramSnapshot interface { | |||
|
|
|||
| // Durations returns the sample values by upper bound for a durationHistogram | |||
| Durations() map[time.Duration]int64 | |||
|
|
|||
| // NumValues returns the number of values which were emitted by this metric | |||
| NumValues() int64 | |||
There was a problem hiding this comment.
The problem with doing this is HistogramSnapshot is an interface... i.e. adding a method to an interface is a breaking version change.
This is one of the things about our current Tally API - we expose everything via interfaces, which is a right PITA. We can't land this like this.
We can make a better testing story in the current version tho. Lets chat offline once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hat it is easier to test.
Add the number of values and durations in order to enable easier histogram testing