Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 support #517

Open
joaogarin opened this issue Dec 30, 2024 · 1 comment
Open

React 19 support #517

joaogarin opened this issue Dec 30, 2024 · 1 comment

Comments

@joaogarin
Copy link
Contributor

Short description

Update to React 19

Expected results

Expected that the react-geosuggest library would work with React 19 and React 19 types

Actual results

Several errors around the return types and other elements that have errors with React 19.

PR #516

Reproduction steps

  1. Go to package.json (or a project using react-geosuggest)
  2. Update react, react-dom and react types to 19.
  3. Run build
  4. See errors

Additional Information

Please copy/paste any additional information you would like to supply (error messages, screenshots, ...)
@joaogarin
Copy link
Contributor Author

joaogarin commented Jan 2, 2025

@yfr any chance we can have a look at this? I think most people will need updating to React 19 soonish, and this would help unblock some of these updates? I did check if all the changes here are compatible with React 18, looks to me like they are quite ok to use also in React 18

Any feedback would appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant