Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of method Value::make_global_ref #32

Open
cireu opened this issue Oct 28, 2020 · 2 comments
Open

Naming of method Value::make_global_ref #32

cireu opened this issue Oct 28, 2020 · 2 comments
Labels
enhancement

Comments

@cireu
Copy link
Contributor

cireu commented Oct 28, 2020

According to https://rust-lang.github.io/api-guidelines/naming.html. I think we'd better to rename make_global_ref to to_global_ref to help user discover this API. What's your opinion?
@cireu
Copy link
Contributor Author

cireu commented Oct 28, 2020

Or even into_global_ref? though Value derives Copy, but it's actually a proxy type of Emacs value, not a POD in true sense.

@ubolonton
Copy link
Owner

Yeah, either to_ or into_ sounds better. I'm leaning towards the former, but I'm not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubolonton @cireu