Store UGID in group cache to handle group renames at provider's end #647
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv-tyagi
force-pushed
the
group-name-consistency
branch
from
483afc8
to
fee1ce2
Compare
|
@adombeck Here is my initial work. Could you please check if I am going in right direction? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #620
As suggested by @adombeck, to identify if a group is renamed at provider's end, we should store UGID along with the GID and group name in the cache and find if there is already a group record with same UGID in cache. In case we find one, we delete the record being pointed by old name in relevant buckets and populate with record containing new name.