Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full portal support #15

Merged

Conversation

sergio-costas
Copy link
Contributor

Due to some changes in GTK and GDK, GDK_DEBUG=portals is required in the environment variables to ensure the use of portals.

More info: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4829

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please check only the options that are relevant.

  • General Maintenance
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • OS (please include version):
  • Any other relevant environment information:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Due to some changes in GTK and GDK, GDK_DEBUG=portals is
required in the environment variables to ensure the use of
portals.

More info: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4829
@sergio-costas
Copy link
Contributor Author

@kenvandine Or maybe we should ask James... (but its id doesn't show in github, don't know why)

@sergio-costas
Copy link
Contributor Author

@sergio-costas sergio-costas merged commit ba10033 into ubuntu:stable Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants