-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YaruBackButton
alignment behavior is inconsistent
#891
Comments
It should be in the leading spot of the appbar, when the page is paned, IMO, just like in the yaru.dart example :) or in the firmware updater / settings app / musicpod / etc |
That sounds like I good idea, but I can't find that in the yaru example? |
I just had a local change with this back button in the _TitleBar but got confused by the many ways in app center to access the navkey and reverted it It could look like in this picture in MusicPod, but then on the snap/deb pages the share and flag buttons need to be moved I suppose |
That looks a lot better indeed, what do you think @anasereijo? |
Indeed! This can work well now that we have approved @Feichtmeier's changes to the layout of the side nav. I am happy to proceed with this, make sure it's present on all pages that can have the back button (search results, app page, etc). |
The issue remains but when I read Taha Tesser correctly, this issue with flutters leading widget in app bars is fixed, I think we can removed this internal center here, I'll have a look |
Depending on whether its style is
round
or not, the button is wrapped in aCenter()
widget (see #531). Consequently, ubuntu/app-center#1622 lead to a misalignment in the App Center's search page:Of course, this can be fixed very easily, but I suppose it's worth making the behavior consistent in yaru 🙂
The text was updated successfully, but these errors were encountered: