Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Cookie core class override #1607

Open
clpetersonucf opened this issue Sep 17, 2024 · 0 comments
Open

Retire Cookie core class override #1607

clpetersonucf opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@clpetersonucf
Copy link
Member

When SameSite cookie requirements first became an issue, FuelPHP did not yet support those headers appropriately out of the box. They are now supported within the core Cookie class, which makes our override copy of the class more or less obsolete. It could potentially be a liability as additions are made to the core class that are not reflected in our own copy.

It should be reasonable to retire our copy of the Cookie class in favor of the one in fuel/core and add the required configs to set the SameSite=None and Secure=true cookie headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants