Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request review of observable:hashes for potential removal from UCO #648

Open
vulnmaster opened this issue Jan 4, 2025 · 0 comments
Open
Labels

Comments

@vulnmaster
Copy link

vulnmaster commented Jan 4, 2025

Bug description

In a discussion on 1/3/2025 between @vulnmaster and @ajnelson-nist, there is some concern that observable:hashes is not needed in the Unified Cyber Ontology as we already have observable:hash

This was in discussion to @vulnmaster building a converter script that converts NIST's NSRL CAID ODATA format to UCO.

We shouldn't need observable:hashes as we can capture multiple hashes in a file facet like this as of UCO v1.4.

{
  "@context": {
    "odata.metadata": "http://github.com/ICMEC/ProjectVic/DataModels/1.2.xml#Media",
    "uco-observable": "https://ontology.unifiedcyberontology.org/uco/observable/",
    "uco-types": "https://ontology.unifiedcyberontology.org/uco/types/",
    "uco-core": "https://ontology.unifiedcyberontology.org/uco/core/",
    "uco-vocabulary": "https://ontology.unifiedcyberontology.org/vocabulary/",
    "kb": "http://example.org/kb/",
    "rdf": "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "rdfs": "http://www.w3.org/2000/01/rdf-schema#",
    "xsd": "http://www.w3.org/2001/XMLSchema#"
  },
  "@graph": [
    {
      "@id": "kb:media-d2d4a2f7-2cea-4b8f-9a72-7df02cc17e6c",
      "@type": "uco-observable:File",
      "categories": 8,
      "facets": [
        {
          "@type": "uco-observable:FileFacet",
          "observable:sizeInBytes": 488,
          "observable:fileName": "build2.art",
          "observable:filePath": "Like a Dragon Gaiden- The Man Who Erased His Name/Content/runtime/media/ylad8/data/artisan",
          "observable:hash": [
            {
              "@type": "uco-types:Hash",
              "types:hashMethod": "MD5",
              "types:hashValue": "588cd1c0e48916d8e7403310402d0a68"
            },
            {
              "@type": "uco-types:Hash",
              "types:hashMethod": "SHA1",
              "types:hashValue": "e65706b487c73e992bab2a50707a9fd8b0bd6866"
            }
          ]
        }
      ]
    }
  ]
}

Suggest review for removal of the property observable:hashes

@ajnelson-nist feel free to add to this in the event that I misinterpreted your thoughts on this.

@vulnmaster vulnmaster added the bug label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant