Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Keyboard shortcut (Mod+Shift+H) does not work in readOnly #3828

Open
michaelbrusegard opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@michaelbrusegard
Copy link

Description

When you are in readOnly mode and want to highlight something you cannot use the keyboard shortcut like you can in editing mode. Since it is possible to highlight in readOnly using the plugin without using the Keyboard shortcut, it makes sense for the keyboard shortcut to also work. The issue is in all browsers.

Reproduction URL

https://platejs.org/docs/highlight

Reproduction steps

1. Go to 'https://platejs.org/docs/highlight'
2. Click on 'Editing mode' -> 'Viewing'
3. Highlight some text
4. Press the keyboard shortcut Mod + Shift + H.
5. Notice that nothing happens or the default browser action is triggered.

If you then exit viewing mode and try the same in editing mode you can see that the keyboard shortcut works.

Plate version

40.2.5

Slate React version

0.111.0

Screenshots

No response

Logs

No response

Browsers

Chrome, Firefox, Safari

@michaelbrusegard michaelbrusegard added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant