Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design project element #14

Closed
mirdaki opened this issue Jan 24, 2018 · 19 comments
Closed

Design project element #14

mirdaki opened this issue Jan 24, 2018 · 19 comments
Assignees
Milestone

Comments

@mirdaki
Copy link
Member

mirdaki commented Jan 24, 2018

Design the look of an individual project item. Mock up with HTML and CSS what it would look like with some example content (don't worry about actually getting the information, that's issue #10). It should have a spot for the name of the project, a description, the project lead, links to the GitHub and other project contributors, and an optional image. It should resize for desktop and mobile devices.

@mirdaki mirdaki added this to the First Release milestone Jan 24, 2018
@jjmorales
Copy link

image

This is the template I built, feedback please

@mirdaki

@jjmorales
Copy link

So there's a spot for the title, project lead, project description, image, github link, and contributors. I filled it all in with random stuff about the migos just so you can see it in action.

@mirdaki
Copy link
Member Author

mirdaki commented Jan 26, 2018

Nice job! It has everything we need and is well laid out. Could you look into different font choices (each part can be a different font too) to make it feel a little more polished? This is a good resource to start

@jjmorales
Copy link

Thanks! Okay will do

@jjmorales
Copy link

image

I changed the fonts and moved the git and contribution section to the middle (I could move it back, just a change so you could decide whether you prefer it on the side or the middle)... are these fonts okay or should I keep looking? What do you think of the placement for the git and contribution, middle or left hand side?

@mirdaki
Copy link
Member Author

mirdaki commented Jan 26, 2018

On the fonts: I think the title font is a bit to block and rough (not sure if that's the right word lol) for a project (makes sense for an album though). Try a few different combinations and post what you like.

On the GitHub link and contributions I think center is fine. One thing we might have to deal with is if the project dosen't have a picture. If that happens the element should adjust appropriately.

@jjmorales
Copy link

jjmorales commented Jan 26, 2018

screen shot 2018-01-26 at 5 09 00 pm

screen shot 2018-01-26 at 5 03 28 pm
screen shot 2018-01-26 at 5 06 29 pm

This is a different font for the title, it's a more simple, sleek and thin look.

Also, in the case that there is no image, you simply have to put the description in a different div leaving the column divs empty, I labeled each portion of code with short comments saying what goes where, I included a screenshot of a chunk of the code so you sort of get the idea of what I was going for. I'm less explicit with what classes in css go to what but I feel those are sort of self explanatory and could be figured out by looking at what code implements what style class.

@mirdaki
Copy link
Member Author

mirdaki commented Jan 26, 2018

I do like title font better. Good job with the comments too. It does look like the GitHub link and contributors isn't quite centered without the picture though. Also can I ask why you're using divs around the h1 and h4?

@jjmorales
Copy link

Ah nice catch, I had them wrapped in divs because I was experimenting with some other organizational styles but then decided against it. I removed them for cleaner code. I'll work on the alignment of the GitHub link and contributors. If we decide that we want those attributes on the left instead of the middle then there's no issue and they remain in the same spot regardless on if there's an image or not. If we want those attributes centered it becomes a little more complicated and I'd need to reformat some stuff a little bit. Do you want me to keep those centered or put them back on the left?

@mirdaki
Copy link
Member Author

mirdaki commented Jan 26, 2018

Lets try centering for now

@jjmorales
Copy link

screen shot 2018-01-26 at 7 11 52 pm
screen shot 2018-01-26 at 7 11 22 pm

I think I got it.

@mirdaki
Copy link
Member Author

mirdaki commented Jan 27, 2018

Nice! Now could you make a list of these to represent different projects to simulate a full page. After that you can merge your code with the dev branch. You could name your files something like project-page.html and project-page.css so they don't get confused for another part.

@jjmorales
Copy link

I filled in the code with random information and bs just so you could see how it looks as a full page. Do you want me to submit it with the example content so they have an idea of what it looks like and where things go?

@mirdaki
Copy link
Member Author

mirdaki commented Jan 27, 2018

Yep! Have a mix of them with and without images

@jjmorales
Copy link

Yes sirrrr I did that. How do I split the files up making one css and one html?

@jjmorales
Copy link

Nevermind I looked it up! I'll merge now

@mirdaki
Copy link
Member Author

mirdaki commented Jan 27, 2018

Nice job!! I'll close this issue now, want another one?

@mirdaki mirdaki closed this as completed Jan 27, 2018
@jjmorales
Copy link

Yeah sure! Did you take a look at the files I submitted?

@mirdaki
Copy link
Member Author

mirdaki commented Jan 27, 2018

I did. The code looks pretty good (and you have a knack for filling out the contributor section lol)! I've assigned you to issue #9!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants