-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on alpine-arm64, actually resolves #180 #195
Conversation
The failing CI checks are strange. I just ran exactly the same actions on my branch and they all passed o.O (ref: https://github.com/zotanmew/node-re2/actions/runs/6757292988/) |
Don't despair — sometimes (well, frequently) Github CI fails for no discernable reasons. I'll re-run the test. |
Hmm, nope, it is reproducible. Apparently, a MacOS runner for Node 21 has no |
Welcome to the beautiful world of Node extensions, where I spent 99% of my time wrangling setup files instead of coding.
From https://docs.python.org/3/whatsnew/3.12.html
Obviously, I don't use I suggest waiting for PS: I kinda thinking of creating a project based on Node-API or even WASM to avoid the dependency compatibility hell. Not sure it'll help. :-( PPS: I hope now people understand why supporting more architectures is not trivial. |
Very strange. It runs successfully on my branch 🥴 https://github.com/zotanmew/node-re2/actions/runs/6757292988 |
It still fails, but worked for me in a separate brunch. Merging... |
a wasm version would be great, you would only need one build for different node versions and architectures. ❤️ |
I'd highly recommend releasing this as soon as possible, this is breaking arm64 docker images, presumably not just for me :)