Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken URLs in preview docs #304

Closed
tkoskela opened this issue Apr 8, 2024 · 2 comments · Fixed by #305
Closed

Broken URLs in preview docs #304

tkoskela opened this issue Apr 8, 2024 · 2 comments · Fixed by #305
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@tkoskela
Copy link
Member

tkoskela commented Apr 8, 2024

The URL rewriting in #295 does not seem to work as intended. I get in https://ukri-excalibur.github.io/excalibur-tests/preview/PR299/ url's on the main page that look like https://ukri-excalibur.github.io/excalibur-tests/preview/PR299/preview/PR299/install/ ie. the preview/PR299 bit appears twice.

@tkoskela tkoskela added the documentation Improvements or additions to documentation label Apr 8, 2024
@giordano
Copy link
Member

giordano commented Apr 8, 2024

I've been looking at the code but struggling to spot what's the error. This is with PR #294 (before #295):

<li><a href="https://ukri-excalibur.github.io/excalibur-tests/install/">Installation</a></li>

This is with PR #295:
<li><a href="https://ukri-excalibur.github.io/excalibur-tests/preview/PR295/install/">Installation</a></li>

I'm really missing what's causing the duplicate preview/PRNNN level. Ok, time to do some debugging.

@giordano
Copy link
Member

giordano commented Apr 8, 2024

Ah, wait, it's the second push within the same PR which is messing this up: 771a201#diff-7fd9bc7707206c4dfa2b00b4bf5684de0c820259a4156c27387ab0f72af9315cR1233. I'm very confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants