Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spack version in CI and add note in docs #297

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Update spack version in CI and add note in docs #297

merged 2 commits into from
Mar 25, 2024

Conversation

tkoskela
Copy link
Member

Closes #296

@kaanolgu
Copy link
Contributor

@tkoskela I just checked it is the conrete_roots function that we call, it seems it was introduced in the version v.20.0 so checking against v.21.0 is fine but could also be v.20.0 if we want to check backwards compatibility
https://spack.readthedocs.io/en/latest/spack.environment.html#spack.environment.Environment.concrete_roots [OK]
https://spack.readthedocs.io/en/v0.20.0/spack.environment.html#spack.environment.Environment.concrete_roots [OK]
https://spack.readthedocs.io/en/v0.19.2/spack.environment.html#spack.environment.Environment.concrete_roots [NOK]

ilectra
ilectra reviewed Mar 25, 2024
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
ilectra
ilectra reviewed Mar 25, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tkoskela tkoskela force-pushed the tk/update-spack-version branch from 170aef3 to 39b30df Compare March 25, 2024 14:28
@tkoskela tkoskela merged commit db6168e into main Mar 25, 2024
6 checks passed
@tkoskela tkoskela deleted the tk/update-spack-version branch March 25, 2024 16:29
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
@tkoskela
Cleanup docs for PR #297
4153cef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilectra ilectra ilectra left review comments

@kaanolgu kaanolgu kaanolgu approved these changes

@giordano giordano Awaiting requested review from giordano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update spack requirement in docs and CI
3 participants
@tkoskela @kaanolgu @ilectra