fix: cannot search for 1-level heading content #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
reviewed
Aug 10, 2023
| @@ -119,7 +119,7 @@ function generateSearchMetadata( | |||
| const tocSections = routeMeta.toc.reduce<ISearchMetadata[0]['sections']>( | |||
| (acc, toc, i) => { | |||
| // exclude demo id, to avoid duplicate | |||
| if (!demoIds.includes(toc.id) && toc.depth > 1) { | |||
| if (!demoIds.includes(toc.id) && toc.depth >= 1) { | |||
There was a problem hiding this comment.
感谢贡献，回想了一下当时的考虑，过滤掉 1 级是为了避免页面搜索和一级标题搜索冗余，因为 dumi 会把页面的一级标题作为页面标题，比如搜索『初始化』可以看到冗余的结果
单就这个问题而言，期望结果是：
- 输入 1 级标题下的文本，能展示结果，且结果的标题只展示页面标题（
什么是 dumi - 什么是 dumi简化成什么是 dumi） - 输入 1 级标题本身，只展示页面结果不展示标题结果
大致效果：
 |
 |
有空的话看看是否容易调整？
There was a problem hiding this comment.
嗯，这里已调整，就是在匹配toc 的 title 的时候，看下是否能匹配页面title, 如果是的话就跳过。就等于过滤掉toc 的搜索结果
Zhou-Bill
force-pushed
the
fix/search-1-level
branch
from
e40b315
to
e6e2c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
#1811
💡 需求背景和解决方案 / Background or solution
searchWorker.ts格式化搜索内容 层级少了一层📝 更新日志 / Changelog