Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new upgrade-replace logic from Helm 3.3 #97

Open
tkrullmann opened this issue Oct 7, 2020 · 0 comments
Open

Support new upgrade-replace logic from Helm 3.3 #97

tkrullmann opened this issue Oct 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@tkrullmann
Copy link
Member

Starting with Helm 3.3, helm upgrade replaces a previous deployment if the history consists entirely of failed deployments. This means that now installation or upgrade can now always be performed with helm upgrade --install, regardless of the previous state of the deployment.

Currently the HelmInstallOrUpgrade task does a helm ls first to check if the deployment has previously failed, and then decides whether to use helm upgrade --install or helm install --replace. For Helm 3.3 we could skip this check because helm upgrade --install would now always behave like this.

However, we also want to keep supporting Helm versions < 3.3, so this would mean we have to read the version using helm version first. But helm version does not make a network call, so it should still be an improvement over helm ls.

@tkrullmann tkrullmann added the enhancement New feature or request label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant