Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Fill-Opacity on Scatter Plot #58

Open
rheubach opened this issue Oct 15, 2021 · 8 comments
Open

Configure Fill-Opacity on Scatter Plot #58

rheubach opened this issue Oct 15, 2021 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@rheubach
Copy link
Contributor

It would be nice to allow graph creators the ability to adjust the Fill-opacity attribute on the circles placed on the scatter plot. You can find a set value for the attribute on the "scatter-dot" circle within the live_scatter.html file.

@rheubach
Copy link
Contributor Author

@alcwhite would this be an easy configuration to add to the scatter plot?

@alcwhite
Copy link
Contributor

@rheubach Yes. Would the same opacity apply to all circles, or should there be circle-specific configuration for this?

@rheubach
Copy link
Contributor Author

rheubach commented Oct 15, 2021

@alcwhite I can't think of situations someone would want them to be different opacities, but I would like to side on the most configurable design. So, let's set it for each individual circle. Plus we can already set a different color for each circle, so it will be consistent with that.

@rheubach rheubach added the good first issue Good for newcomers label Oct 15, 2021
@markeasterling
Copy link

@rheubach I'd like to try to do this. not sure how to assign myself

@rheubach
Copy link
Contributor Author

@markeasterling got you covered! I also invited you to join the uncharted team so you can create PRs without having to fork the repo.

@markeasterling
Copy link

thanks Beau!

@markeasterling
Copy link

hey, @rheubach I see that 0.6 was hardcoded in for point's fill opacity. would you like that to be the default value if one isn't supplied?

@rheubach
Copy link
Contributor Author

@markeasterling Yes, let's make 0.6 the default. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants