Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure up-to-date dependencies in ESLint workflows. #218

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

OhmSpectator
Copy link
Member

@OhmSpectator OhmSpectator commented Jul 11, 2024

Description

This PR updates the ESLint workflows for both frontend and backend by removing the redundant restore-keys. This change ensures that the workflows always use up-to-date dependencies and do not fall back to outdated ones when new dependencies are added.

Related Issues

None

How Was This Tested?

Will be tested as part of the PR review

Checklist

Before submitting your PR, please review the following:

  • Commit messages follow the standard template.
  • All commits are signed.
  • Related issues are mentioned in the description above.
  • I have followed the project's directory structure.
  • Linter checks have been passed.

Additional Comments (if any):

Test

Summary by CodeRabbit

  • Chores
    • Updated ESLint workflows to improve dependency caching behavior by removing restore-keys parameter.

Removed the redundant restore-keys from the ESLint workflows for both
frontend and backend to ensure we use up-to-date dependencies and avoid
fallback issues when new dependencies are added.

Signed-off-by: Nikolay Martyanov <[email protected]>
Copy link

coderabbitai bot commented Jul 11, 2024

Walkthrough

The main change involves the removal of the restore-keys parameter from the caching configuration in two GitHub Actions workflow files. This affects how dependencies are restored during the execution of these workflows, potentially altering the efficiency and speed of the caching process.

Changes

Files Change Summary
.github/workflows/eslint-back.yml Removed restore-keys parameter under the caching job.
.github/workflows/eslint-front.yml Removed restore-keys parameter under the caching job.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 17456ae and de594d3.

Files selected for processing (2)
  • .github/workflows/eslint-back.yml (1 hunks)
  • .github/workflows/eslint-front.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/eslint-back.yml
  • .github/workflows/eslint-front.yml

@OhmSpectator OhmSpectator merged commit 2e62223 into main Jul 11, 2024
14 checks passed
@OhmSpectator OhmSpectator deleted the fix-nmp-caches-in-gh-wf branch July 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant