Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathTemplateHandler description points to deprecated functionality. #21

Open
liamsc opened this issue Nov 27, 2018 · 1 comment
Open

Comments

@liamsc
Copy link

liamsc commented Nov 27, 2018

Undertow's 2.0 docs state:

Path Template
Similar to the path handler, however the path template handler allows you to use URI template expressions in the path, for example /rest/{name}. The value of the relevant path template items are stored as an attachment on the exchange, under the io.undertow.server.handlers.PathTemplateHandler#PATH_TEMPLATE_MATCH attachment key.

ref: http://undertow.io/undertow-docs/undertow-docs-2.0.0/index.html#built-in-handlers

However when I navigate to the PathTemplateHandler I see that the PATH_TEMPLATE_MATCH is deprecated.

 /** @deprecated */
    @Deprecated
    public static final AttachmentKey<PathTemplateHandler.PathTemplateMatch> PATH_TEMPLATE_MATCH = AttachmentKey.create(PathTemplateHandler.PathTemplateMatch.class);

The docs should reflect non-deprecated functionality here.

For reference I am using the following versions of undertow in Maven:

 <properties>
        <undertow.version>2.0.15.Final</undertow.version>
  </properties>

    <dependencies>
        <dependency>
            <groupId>io.undertow</groupId>
            <artifactId>undertow-core</artifactId>
            <version>${undertow.version}</version>
        </dependency>
        <dependency>
            <groupId>io.undertow</groupId>
            <artifactId>undertow-servlet</artifactId>
            <version>${undertow.version}</version>
        </dependency>
        <dependency>
            <groupId>io.undertow</groupId>
            <artifactId>undertow-websockets-jsr</artifactId>
            <version>${undertow.version}</version>
        </dependency>
    </dependencies>
@fl4via
Copy link
Member

fl4via commented Apr 26, 2020

@liamsc good point! I'll review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants