Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteGaussianProcess is conceptually unsound #87

Open
marcelluethi opened this issue Oct 12, 2015 · 1 comment
Open

DiscreteGaussianProcess is conceptually unsound #87

marcelluethi opened this issue Oct 12, 2015 · 1 comment

Comments

@marcelluethi
Copy link
Contributor

The DiscreteGaussianProcess is a finite view obtained by sampling a finite number of points from a GaussianProcess. This is only sound if the sampling is done uniformly, and with sufficiently many points such that the characteristics of the GP can be represented. However, the current implementation does not make sure that this is the case.

Problems that appear include:

  • The basis functions are not necessarily orthogonal
  • The probabilities (e.g. logpdf, pdf) of the distribution is dependent on the sampling
@marcelluethi
Copy link
Contributor Author

A potential solution is now available thanks to the PivotedCholesky approximation. It should be possible to apply the PivotedCholesky decomposition on the kernel of the Gaussian process, in order to achieve a proper orthogonalization of the basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant