Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homedir for non root user #61

Merged
merged 1 commit into from
May 27, 2018
Merged

Update homedir for non root user #61

merged 1 commit into from
May 27, 2018

Conversation

kjonick1
Copy link
Member

This doesn't work with the container entrypoint script. That sets the HOME=/home/user. Ruby expects to find the aws credentials in ~/.aws. Otherwise, we get the following error:

Aws::Errors::MissingCredentialsError: unable to sign request without credentials set

Copy link
Member

@disaac disaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disaac
Copy link
Member

disaac commented May 23, 2018

@kjonick1 On a side note we previously handled both the UID and GID when launching the container. This was changed to just use the UID which in most cases should be fine but on systems like Bamboo dumping artifacts from the container may be problematic depending on the permissions.

@yuhunglin
Copy link
Contributor

@kjonick1 #63 is going to introduce some changes to where the gem is sourced from (and i'll need to make updates to the CI container), so we should probably merge this before that, or come back around and rebase this PR.

@kjonick1 kjonick1 merged commit 5fa9c82 into master May 27, 2018
@kjonick1 kjonick1 deleted the kj-fix-user-home branch May 27, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants