-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.8.0 #63
Conversation
@blakeneyops In going with the CI flow, merges to master will auto-push the gem to rubygems in the deploy step |
@@ -16,40 +16,33 @@ Gem::Specification.new do |spec| | |||
spec.homepage = "https://unif.io" | |||
spec.license = "MPL-2.0" | |||
|
|||
if spec.respond_to?(:metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW we can also use the metadata for the gem to store generic k-v.
task 'consul_load' do | ||
load_yaml("#{ENV['CONSUL_KV_FILE']}") | ||
end | ||
require 'covalence/consul_tasks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stuff above is basically rolled into this covalence/consul_tasks
@@ -6,7 +6,7 @@ class ShellInterpolation | |||
|
|||
def self.parse_shell(input) | |||
Covalence::LOGGER.info "Evaluating requested interpolation: \"#{input}\"" | |||
matches = input.scan(/.?\$\([^)]*\)/) | |||
matches = input.scan(/.?\$\([^)]*\)+/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imperfect fix for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means no spaces allowed right? No big deal but should probably put it as a caveat or known limitation in the README
Example with spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, hence imperfect fix, i'll amend the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gem signin | ||
gem build covalence.gemspec | ||
COVALENCE_VERSION=$(ruby -e "require \"#{Dir.pwd}/lib/covalence/version\"; puts Covalence::VERSION") | ||
gem push covalence-${COVALENCE_VERSION}.gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably be nice to ghr
the launcher and the bin/covalence
script together with the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create an issue for the interpolation bug fix if we don't have one already and we can track it there and use that to reference any limitations. That way if someone encounters it a google search for issue search will return the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Ruby version bumped to 2.5.1 - Gems updated to support new ruby version. - **Gem now hosted on rubygems instead of gemfury** - Should be able to avoid the gem repo listing for gemfury in `Gemfile`s - Feature: Rolled in consul-kv capabilities into `covalence/consul-tasks.rb' * Does not natively handle encrypted sops files yet, keeping that step separate for the time being - Feature: Introducing sops capability for encrypting and decrypting files. New sops tasks in `covalence/sops-tasks.rb'. * Uses file suffix naming conventions to handle automatic path grepping to encrypt and decrypt files. The decrypt file suffix should be added to `.gitignore`. - Bug fix: Handle nested shell interpolation values. Probably not a long term fix unfortunately though.
avoid the gem repo listing for gemfury in
Gemfile
sstep separate for the time being
files. New sops tasks in `covalence/sops-tasks.rb'.
grepping to encrypt and decrypt files. The decrypt file suffix should be
added to
.gitignore
.term fix unfortunately though.