Stable/release GitHub action does not have version annotations

[nderjung]

Feature request summary

See: https://github.com/unikraft/kraftkit/actions/runs/7164563288/job/19505330651#step:8:933

Describe alternatives

No response

Related architectures

None

Related platforms

None

Additional context

No response

[craciunoiuc]

Became more important now as we do releases more often.

[camnwalter]

Hi, I'm a computer science student at the University of Texas at Austin, and my partner and I would like to contribute and solve this issue. We are interested in working on this if it is still open. Thank you.

Can you explain it a bit more? The linked action has expired.

[nderjung]

@craciunoiuc was this fixed?

[craciunoiuc]

It's not fixed, I just manually rebuild after this finishes.

@camnwalter you can take a look if you want.

Basically the github-action:v0 image that is built here[1][2] contains a version of kraftkit with the version ~dirty. This makes the update-available prompt pop up everywhere in the CI which si a bit annoying.

To build the image correctly I use this line from @nderjung: DOCKER=docker IMAGE_TAG=blahblahblah make buildenv-myself && KRAFTKIT_VERSION=blahblahblah DOCKER=docker make buildenv-github-action

[1] https://github.com/unikraft/kraftkit/blob/staging/.github/workflows/github-action.yaml
[2] https://github.com/unikraft/kraftkit/blob/staging/buildenvs/github-action.Dockerfile

[camnwalter]

It's not fixed, I just manually rebuild after this finishes.

@camnwalter you can take a look if you want.

Basically the github-action:v0 image that is built here[1][2] contains a version of kraftkit with the version ~dirty. This makes the update-available prompt pop up everywhere in the CI which si a bit annoying.

To build the image correctly I use this line from @nderjung: DOCKER=docker IMAGE_TAG=blahblahblah make buildenv-myself && KRAFTKIT_VERSION=blahblahblah DOCKER=docker make buildenv-github-action

[1] https://github.com/unikraft/kraftkit/blob/staging/.github/workflows/github-action.yaml [2] https://github.com/unikraft/kraftkit/blob/staging/buildenvs/github-action.Dockerfile

Did you fix this in 7867daa?

[craciunoiuc]

I think so, but I'm not 100% sure

[nderjung]

GHA still reports -dirty

[craciunoiuc]

@camnwalter still up for grabs 😢

[camnwalter]

Ok, I'll try looking into it