Bad association leads to incomprehensible error message

[mmower]

Hi Jon.

Upmin looks very good but can I suggest adding a model-association validation phase? Because right now Upmin is very brittle around errors in the code.

I had two associations in my app code that were invalid. They both broke Upmin, the second with a pretty incomprehensible stack trace (https://gist.githubusercontent.com/mmower/b8697b6f1bd8889da09b/raw/aeb4c369bb12d3ad72084d510afcc5d173d038f9/gistfile1.txt)

It's not Upmin's fault that I had bad code in my app (one was an association that was no longer present but still declared, one was an association with the wrong name) but it would have been better if, instead of blowing up on messaging nil, it could have told me:

"Project#users relationship is bad"

Since Upmin is likely to depend on the applications models & relationships being valid for its operation a belt & braces check of each may be no bad thing.

Kind regards,

Matt

[joncalhoun]

Hi Matt,

Thanks for the feedback, and I completely agree upmin-admin needs to be a lot less brittle with errors, and I appreciate you pointing out this bug so I can fix it up.

The stack trace is (oddly) useful for me, so thanks for providing it. Is it possible to get an example of what you mean by "an association with the wrong name"? I know what you mean by one no longer being present, but I am not 100% certain on the wrong name one and I would like to make sure it gets tested as well.

Thanks,
JOn