-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a way to combine rate limits? #126
Comments
Ended up implementing this but unsure if there is a better way: export const rateLimit = async (domain: string, maxRetries = 3) => {
for (let i = 0; i < maxRetries; i++) {
try {
const { success, pending, reset } =
await ratelimit.handinger.blockUntilReady("api", 180_000);
const msToReset = Math.max(0, reset - Date.now());
const { success: successDomain, pending: pendingDomain } =
await ratelimit.handingerDomain.blockUntilReady(domain, msToReset);
waitUntil(Promise.all([pending, pendingDomain]));
if (success && successDomain) {
return;
}
throw new Error("Handinger Ratelimit exceeded");
} catch (error) {
if (i === maxRetries - 1) throw error;
console.warn(
`Rate limit retry ${i + 1}/${maxRetries} failed. Retrying...`,
);
await new Promise((resolve) => setTimeout(resolve, 10000));
}
}
throw new Error("Handinger Ratelimit exceeded");
}; |
Hey @david8z, what is it that you're trying to achieve here? If you could provide more details about the logic/purpose, I could come up with something. |
Hey @fahreddinozcan basically the idea is finding an efficient way of combining two limits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the optimal way to combine two rate limits together?
We could define:
And then await both:
But this doesn't assures that once resolved none are blocked as one could resolve much faster than the other one.
The text was updated successfully, but these errors were encountered: