Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validación: no debería pedir override para el initialize de los test, clases y objetos #123

Closed
julimr opened this issue Jun 3, 2022 · 2 comments · Fixed by #176
Closed

Validación: no debería pedir override para el initialize de los test, clases y objetos #123

julimr opened this issue Jun 3, 2022 · 2 comments · Fixed by #176
Assignees
@juanbono
Labels
good first issue Good for newcomers

Comments

@julimr
Copy link
Contributor

julimr commented Jun 3, 2022

Error en consola:
[WARNING]: shouldUseOverrideKeyword at src/temporada1.wtest:15

Link al repo
@julimr julimr changed the title Validacion: no debería pedir override para el initialize de los test, clases y objetos Validación: no debería pedir override para el initialize de los test, clases y objetos Jun 3, 2022
@nscarcella
Copy link
Member

Esto se había discutido pero no creo que hayamos llegado a una conclusión. A mí la verdad me importa poco, pero tal vez habría que chequear con el resto...

@fdodino
Copy link
Contributor

fdodino commented Oct 11, 2023

+1 a que no lo pida, al menos en los describes queda feo

image

@juanbono juanbono self-assigned this Oct 13, 2023
@juanbono juanbono mentioned this issue Oct 13, 2023
Merged
@PalumboN PalumboN linked a pull request Oct 18, 2023 that will close this issue
make shouldUseOverrideKeyword ignore initialize method #176
Merged
@fdodino fdodino added the good first issue Good for newcomers label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanbono juanbono

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make shouldUseOverrideKeyword ignore initialize method juanbono/wollok-ts
4 participants
@nscarcella @juanbono @fdodino @julimr